Store comparator hits in the CLCT (CCLUT-4) #29233
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29233/14262
|
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: L1Trigger/CSCTriggerPrimitives @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Hi, can someone initiate the tests please? |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
There are some failures in the L1T and L1TEMU directories, none in the CSC directory. Not sure where those failures are coming from, but they are not related to this PR. |
|
@rekovic Do you have any more questions on this pull request? |
|
do you have other comments @rekovic ? |
dildick
changed the title
|
@rekovic ? |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29233/14676
|
|
Pull request #29233 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
silviodonato
changed the title
|
+1 |
dildick
deleted the
from-CMSSW_11_1_X_2020-03-18-1100-store-comp-hits-clct-pattern
branch
dildick
changed the title
PR description:
This PR saves the comparator hits that were used to build a CLCT in a ComparatorContainer. (Similar to how a CSCSegment has access to the CSCRecHit2Ds.) The relevant change is in function
patternFinding, which called for both the trigger and the pre-trigger. This function now also identifies all hits that were part of a particular pattern. An intermediate pattern map keeps track of all comparator hits, for each key half-strip and for each pattern Id. Ultimately, only the comparator hits for the best pattern are stored in the CLCT.No changes to the actual trigger logic have been made. No changes are expected in the output.
PR validation:
Tested with WF 22034.0.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
@tahuang1991