Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.1.X [Tracker Alignment] All-in-one tool support of multiple tags in user-inputed sqlite file #30078

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 2, 2020

backport of #30077

PR description:

In this commit: ca150f3 we introduced a new method in order to read local sqlite files in the tracker alignment all-in-one tool, by using conddblib to check contents of sqlite files.
In the original implementation in PR #29339 I did not foresee to put more than one tag into a local sqlite file, but this appears to be a required use case.
The issue and the fix have been provided by @adewit.
I profit of this PR also to update the unit test to cover this use-case.

PR validation:

Relies on the existing unit test in the subsystem. I have tested this in CMSSW_11_1_X_2020-06-02-1100

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a verbatim backport of #30077

@mmusich
Copy link
Contributor Author

mmusich commented Jun 2, 2020

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_1_X.

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 2, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6738/console Started: 2020/06/02 16:02

@mmusich mmusich changed the title Tk all in one support multiple tags 11 1 x 11.1.X [Tracker Alignment] All-in-one tool support of multiple tags in user-inputed sqlite file Jun 2, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

+1
Tested at: 264f873
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aaf5c/6738/summary.html
CMSSW: CMSSW_11_1_X_2020-06-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aaf5c/6738/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 45
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780697
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

merge
alca: @pohsun @tlampen @tocheng @christopheralanwest
please let me know if you have any comments, I'm merging this now because I'm building a preliminary 11_1_0_pre9 release.

@cmsbuild cmsbuild merged commit 1f9bca2 into cms-sw:CMSSW_11_1_X Jun 3, 2020
@tlampen
Copy link
Contributor

tlampen commented Jun 4, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants