-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tracker Alignment all-in-one tool for py3 (again) #29339
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29339/14429
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/OfflineValidation @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Thanks! |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
wait... I missed a commit! |
@cmsbuild, please abort |
The code-checks are being triggered in jenkins. |
OK, now is OK for testing. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29339/14430
|
@cmsbuild, please test for CMSSW_11_1_PY3_X Let me try again to trigger py3 tests. |
The tests are being triggered in jenkins.
|
+1 |
Comparison is ready Comparison Summary:
|
These failures must come from something else. The update is here is not affecting anything run in relvals. |
Right - Py3 and py2 won’t give the same results.
On Mar 31, 2020, at 1:51 PM, Marco Musich <notifications@github.com<mailto:notifications@github.com>> wrote:
DQMHistoTests: Total failures: 723
These failures must come from something else. The update is here is not affecting anything run in relvals.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29339 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ2QF52EYI4SR5MQIU3RKHKKPANCNFSM4LWYGRDQ>.
|
kind reminder @pohsun @tlampen @tocheng @christopheralanwest |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
resolves #29337
PR description:
Title says it all. Removed contraption to list tags in favor of DB group supported
conddbllib
commandsPR validation:
Unit test has been exercised successfully with this PR in
CMSSW_11_1_PY3_X_2020-03-29-2300
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, and no backport is meant.