Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tracker Alignment all-in-one tool for py3 (again) #29339

Merged
merged 3 commits into from
Apr 7, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 30, 2020

resolves #29337

PR description:

Title says it all. Removed contraption to list tags in favor of DB group supported conddbllib commands

PR validation:

Unit test has been exercised successfully with this PR in CMSSW_11_1_PY3_X_2020-03-29-2300

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, and no backport is meant.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29339/14429

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

Thanks!

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 30, 2020

wait... I missed a commit!

@makortel
Copy link
Contributor

@cmsbuild, please abort

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 30, 2020

OK, now is OK for testing.
@makortel is there a way to instruct the bot to run under a python3 build?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29339/14430

  • This PR adds an extra 20KB to repository

@makortel
Copy link
Contributor

@cmsbuild, please test for CMSSW_11_1_PY3_X

Let me try again to trigger py3 tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 30, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 8f965ad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e4542/5453/summary.html
CMSSW: CMSSW_11_1_PY3_X_2020-03-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e4542/5453/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3562 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2693610
  • DQMHistoTests: Total failures: 723
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692887
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Mar 31, 2020

DQMHistoTests: Total failures: 723

These failures must come from something else. The update is here is not affecting anything run in relvals.

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 31, 2020 via email

@silviodonato
Copy link
Contributor

kind reminder @pohsun @tlampen @tocheng @christopheralanwest

@pohsun
Copy link

pohsun commented Apr 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3 failure in TkAlAllInOneTool unit test
6 participants