Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.1.X] Fix several bugs introduced in the Pixel PI #29980

Merged
merged 3 commits into from
May 28, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 25, 2020

backport of #29938

PR description:

After PR #29864 has been merged, it has been possible to visually inspect the rendering of all the newly added plots at ConDBBrowser.
This has revealed that several of the plots introduced in PR #29864 had some problems in the rendering in the browser. This PR aims to fix this, as well as addressing some of the comments received at #29864 (review)

PR validation:

Individual plots have been tested by hand, (see results at link1, link2 and link3 ) . Moreover this branch is passing standard unit tests provided in the package.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #29938

@mmusich
Copy link
Contributor Author

mmusich commented May 25, 2020

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2020

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_1_X.

It involves the following packages:

CondCore/SiPixelPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 25, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6574/console Started: 2020/05/25 19:05

@cmsbuild
Copy link
Contributor

+1
Tested at: 9bdb059
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea4f6/6574/summary.html
CMSSW: CMSSW_11_1_X_2020-05-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea4f6/6574/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780704
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@ggovi
Copy link
Contributor

ggovi commented May 27, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ea60d76 into cms-sw:CMSSW_11_1_X May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants