-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.1.X] Fix several bugs introduced in the Pixel PI #29980
[11.1.X] Fix several bugs introduced in the Pixel PI #29980
Conversation
type bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_1_X. It involves the following packages: CondCore/SiPixelPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #29938
PR description:
After PR #29864 has been merged, it has been possible to visually inspect the rendering of all the newly added plots at ConDBBrowser.
This has revealed that several of the plots introduced in PR #29864 had some problems in the rendering in the browser. This PR aims to fix this, as well as addressing some of the comments received at #29864 (review)
PR validation:
Individual plots have been tested by hand, (see results at link1, link2 and link3 ) . Moreover this branch is passing standard unit tests provided in the package.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is a backport of #29938