-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payload Inspector] Add more SiPixel inspection classes #29864
[Payload Inspector] Add more SiPixel inspection classes #29864
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/SiPixelPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@silviodonato sure, but please point to an example to either one of these. To clarify a bit in advance:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here some examples. std::cout
was in test
, it is not problematic. About the constants, even if they are trivial, I think it is better to define a constexpr
, especially if the same number is repeated in several points.
} else { | ||
st->SetTextColor(plot.second->GetLineColor()); | ||
} | ||
SiPixelPI::adjustStats(st, 0.13, 0.85 - index * 0.08, 0.36, 0.93 - index * 0.08); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numbers
PR description:
This PR introduces several improvement of the SiPixel Payload Inspector suite:
SiPixelTemplate
Condition Format;Phase1PixelMaps
andPixelRegionContainers
in order to display cleaner Pixel Tracker Maps and values / comparison plots split by Layer (Barrel) / Ring (Endcap);SiStripLorentzAngle
andSiPixelGainCalibrationOffline(ForHLT)
;PR validation:
Relies on the existing and newly introduced unit tests.
All the new plots have been tested also by hand; few examples are reproduced here:
PixelRegionContainers
comparing twoSiPixelGainCalibrationOffline
payloads from two different tagsPhase1PixelMaps
of the assume value of μH for one payload ofSiPixelTemplate
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and no backport is intended.