-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FastTimerService easier to use #28874
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28874/13644
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: HLTrigger/Timer @cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@kpedro88 I cannot actually test it this week, and I'm thinking it could be useful to have the default behaviour in a cff file as well - but I can add that next week. |
+1 |
ping @cmsbuild |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The FastTimerService is used as the basis for circles (among other things).
The twiki page (linked above) describes how to use it, but requires manually editing configs generated by cmsDriver.
To make this easier to use, I put the code from the twiki into some functions that can be given to cmsDriver using
--customise
:customise_timer_service
customise_timer_service_singlejob
customise_timer_service_multirun
customise_timer_service_print
I also added a simple harvesting config (which has to run standalone, so a customise function is not appropriate), which includes a
multirun
command-line argument.@fwyzard if you agree with this approach, we can update the twiki to point out the availability of these convenience functions.
PR validation:
Tested the various customise functions and observed that they ran successfully and provided the expected input.