ConditionFormats/Serialization: Update eos portable archive to work with boost 1.69.0+

[gartung]

PR description:

Update eos portable archive to work with boost 1.69.0+
Taken from daldegam/eos-portable-archive#2
This replaces include path to fpclassify.hpp and endian.hpp for changes in 1.69.00 and changes the functions called based on boost version or boost header settings.

PR validation:

ConditionFormats tests?

NB. Updating to boost 1.69.0 also changes the signals interface which breaks the build because libboost_signals is no longer built.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28893/13673

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28893/13673/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28893/13673/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

thanks @gartung , did not know that it was taken from https://github.com/daldegam/eos-portable-archive . Are there any cms changes on top of daldegam/eos-portable-archive ? How about moving it to external?

FYI @ggovi

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28893/13674

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

CondFormats/Serialization

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[gartung]

I don't know that this was taken from there. I searched github for the error message I am getting trying to build with boost 1.70.0 and found that pull request.

A search of github shows many copies of eos header names.

There are build errors in
CondFormats/Serialization/src/templateInstantiations.cc
that I am trying to understand.

[gartung]

There are two repos on github for eos-portable-archive that have pr's with the update

https://github.com/search?q=eos-portable-archive&type=Repositories

duncanka/eos-portable-archive#2

The second repo at least links to the original project page:

https://archive.codeplex.com/?p=epa

which has a link to the original archive.

My web browser generated a warning about the website though.

[gartung]

The errors I am seeing are for duplicate instantiations which seems to be related to this change

commit 8369ace830dbadbaef3969d4d1f60b466bd560ba
Author: Andreas Pfeiffer <andreas.pfeiffer@cern.ch>
Date:   Fri Oct 3 09:43:36 2014 +0200

    moved template instantiation out of eos files into CondFormats/Serialization lib, added usage of CondFormats/Serialization to BuildFiles who need the lib

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28893/13676

• This PR adds an extra 32KB to repository

[smuzaffar]

@ggovi changes in CondFormats/Serialization looks good and they only effect boost version >= 1.69 which we do not have yet in cmssw. So this PR is safe to go in with boost 1.67 (which is what we have in cmssw).

We have tested these changes with boost version 1.72 ( #28893 (comment) ) and it does not break any thing. I would suggest to merge this in CMSSW and start testing boost 1.72 in DEVEL IB.

[ggovi]

@smuzaffar
sounds good, thanks!

[ggovi]

+1

[smuzaffar]

@franzoni , @pohsun , @tlampen , @tocheng , @christopheralanwest can you please sign this change for alca?

[smuzaffar]

@benkrikler, @rekovic can you please sign this ( and https://github.com/cms-sw/cmssw/pull/28893/files#diff-d0dc19617f53a94d299fd1f591d10c6fR10 ) for l1 so that we can proceed with boost 1.72 testing in DEVEL IBs?

[christopheralanwest]

+1

[smuzaffar]

@silviodonato , can we get ths in now? This will help testing boost 1.72 in DEVEL IBs.

[smuzaffar]

@silviodonato , can we get this in? only L1 signatures are missing and changes for L1 are trivial (included just assert header)

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1