-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix testSiStripPayloadInspector for Py3 #28842
Fix testSiStripPayloadInspector for Py3 #28842
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28842/13591
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
3331d7d
to
9a43cad
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28842/13592
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/SiStripPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
please test for CMSSW_11_1_PY3_X |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Kind reminder to @ggovi |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
resolves #28837
PR description:
Title says it all. Changes made in order to make
testSiStripPayloadInspector
work in python3.PR validation:
PR has been tested in Py3 environment in
CMSSW_11_1_PY3_X_2020-01-30-2300
Validation relies on existing unit tests, which now run successfully.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and no backport is meant.