Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondCore unit tests failing for PY3 IBs due to use of boost_python #29983

Closed
smuzaffar opened this issue May 26, 2020 · 7 comments · Fixed by #30008
Closed

CondCore unit tests failing for PY3 IBs due to use of boost_python #29983

smuzaffar opened this issue May 26, 2020 · 7 comments · Fixed by #30008

Comments

@smuzaffar
Copy link
Contributor

@ggovi , many CodeCore unit tests are failing in PY3 IBs with error like [a]. Problem is that in PY3 IBs , the default python is python3 which these unit tests are linked to boost_python which was build against python2. In past we have avoided such issues by replacing boost_python with pybind11. Can you please look in to these tests and use PyBind11 instead of boost_python?

[a]

===== Test "testAlCaRecoTriggerBitsPayloadInspector" ====
Could not find platform independent libraries <prefix>
Could not find platform dependent libraries <exec_prefix>
Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
ImportError: No module named site

---> test testAlCaRecoTriggerBitsPayloadInspector had ERRORS
 
^^^^ End Test testAlCaRecoTriggerBitsPayloadInspector ^^^^
@smuzaffar
Copy link
Contributor Author

assign db

@cmsbuild
Copy link
Contributor

A new Issue was created by @smuzaffar Malik Shahzad Muzaffar.

@Dr15Jones, @silviodonato, @dpiparo, @smuzaffar, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

New categories assigned: db

@ggovi you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mmusich
Copy link
Contributor

mmusich commented May 26, 2020

I think this issue is caused by the integration of PR #29622.
In PR #29993 I address the issue in a similar fashion as done PR #28842 which was fixing issue #28837.
Probably PyBind11 is the best solution though I suspect that needs a more thorough re-thinking of the payload inspector code. My solution at least will remove the unit test failures.

@smuzaffar
Copy link
Contributor Author

@mmusich
Copy link
Contributor

mmusich commented May 28, 2020

@smuzaffar see #30008

@smuzaffar
Copy link
Contributor Author

thanks @mmusich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants