Tracking DQM: miscellaneous fixes #28823

mmusich · 2020-01-29T20:57:19Z

PR description:

The aim of this PR is fix various plots in Tracking DQM:

the DistanceOfClosestApproachToBSdz plot originally included in New plots for Tracking Workspace #27330 has x-axis range too small (actually ~ half of the statistics goes into the overflow bins right now, see e.g. https://tinyurl.com/smcjqap)
the target directory of the Tracking efficiency plots (using muons) is changed, solving long standing issue Adding in Muon Efficiency Maps #23614 (comment)
the file DQM/TrackingMonitorSource/python/TrackingSourceConfigTier0_Cosmic_cff.py is apparently an unused copy of DQM/TrackingMonitorSource/python/TrackingSourceConfig_Tier0_Cosmic_cff.py, so it is removed.

PR validation:

Minimal standard integration tests have been run:

runTheMatrix.py -l 11634.0 -t 4 -j 8 --command='-n 100'
runTheMatrix.py -l 7.22,7.21,7.4,7.3,138.1 -t 4 -j 8

The Beam Spot distance of closest approach with the new x-axis looks like this:

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport and no backport is intended.
cc:
@mtosi @sroychow @arossi83

…sion mode

cmsbuild · 2020-01-29T20:59:22Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-29T21:10:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28823/13543

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622

cmsbuild · 2020-01-29T21:10:40Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorSource

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2020-01-30T08:12:03Z

please test

cmsbuild · 2020-01-30T08:12:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4423/console Started: 2020/01/30 09:14

cmsbuild · 2020-01-30T09:32:44Z

+1
Tested at: 3a1efdb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-421038/4423/summary.html
CMSSW: CMSSW_11_1_X_2020-01-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-01-30T09:32:48Z

Comparison job queued.

schneiml · 2020-01-30T10:56:42Z

Hi @mmusich , while you are at it, please be aware of this observation: #28622 (comment)

Specifically:

Tracking / TrackParameters / PUmonitoring: multi-filled, booked multiple times by multiple instances of the same analyzer.

This is not really a big problem since all analyzers fill the same plots with the same values, but after #28622 these plots will have an inflated number of entries (since all the fill's will go to the same histogram). Currently, the different module instances fill independent histograms and an arbitrary one of these will be saved in the end, which does not make much sense but is fine as long as all the modules produce the same output.

mmusich · 2020-01-30T11:00:46Z

@schneiml thanks for the heads-up but this goes well beyond the scope of this PR. Let's keep it separate. Thanks.

cmsbuild · 2020-01-30T11:09:02Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-421038/4423/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696562
DQMHistoTests: Total failures: 96
DQMHistoTests: Total nulls: 95
DQMHistoTests: Total successes: 2696025
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 7.912 KiB( 33 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 0.344 KiB Tracking/TrackParameters
Checked 147 log files, 16 edm output root files, 34 DQM output files

jfernan2 · 2020-01-30T11:21:07Z

@mmusich Apart from the changes you described in the PR header, it looks like there are some plots which get no entries now in Tracking / TrackParameters / TrackEfficiency , those with E/eff string in the name, I guess computing efficiencies
E.g. https://tinyurl.com/ucb95te
Is this change understood? Thanks

cmsbuild · 2020-01-30T14:59:42Z

The code-checks are being triggered in jenkins.

mmusich · 2020-01-30T15:00:09Z

Is this change understood? Thanks

@jfernan2 , yes addressed at: a5b5a16

re-tested with wf. 20434.0:

Before	After

cmsbuild · 2020-01-30T15:11:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28823/13558

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622

cmsbuild · 2020-01-30T15:11:33Z

Pull request #28823 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

jfernan2 · 2020-01-31T07:49:02Z

please test

cmsbuild · 2020-01-31T07:49:25Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4442/console Started: 2020/01/31 08:54

cmsbuild · 2020-01-31T09:07:18Z

+1
Tested at: a5b5a16
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-421038/4442/summary.html
CMSSW: CMSSW_11_1_X_2020-01-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-01-31T09:07:22Z

Comparison job queued.

schneiml · 2020-01-31T09:33:58Z

@mtosi to be more specific, e.g. Tracking/TrackParameters/generalTracks/PUmonitoring/NumberOfPVtxVsGoodPVtx is booked in wf 136.85 step3 by

TrackingMonitor:TrackSeedMondetachedQuadStep@beginRun
TrackingMonitor:TrackSeedMondetachedTripletStep@beginRun
TrackingMonitor:TrackSeedMonhighPtTripletStep@beginRun
TrackingMonitor:TrackSeedMoninitialStep@beginRun
TrackingMonitor:TrackSeedMonjetCoreRegionalStep@beginRun
TrackingMonitor:TrackSeedMonlowPtQuadStep@beginRun
TrackingMonitor:TrackSeedMonlowPtTripletStep@beginRun
TrackingMonitor:TrackSeedMonmixedTripletStep@beginRun
TrackingMonitor:TrackSeedMonmuonSeededStepInOut@beginRun
TrackingMonitor:TrackSeedMonmuonSeededStepOutIn@beginRun
TrackingMonitor:TrackSeedMonpixelLessStep@beginRun
TrackingMonitor:TrackSeedMonpixelPairStep@beginRun
TrackingMonitor:TrackSeedMontobTecStep@beginRun
TrackingMonitor:TrackerCollisionSelectedTrackMonCommongeneralTracks@beginRun

I assume it's the same for all in this folder. IIRC there are more colliding groups in other workflows.

cmsbuild · 2020-01-31T10:37:30Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-421038/4442/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696562
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 95
DQMHistoTests: Total successes: 2696118
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 7.912 KiB( 33 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 0.344 KiB Tracking/TrackParameters
Checked 147 log files, 16 edm output root files, 34 DQM output files

jfernan2 · 2020-01-31T13:53:58Z

+1
For what this PR changes in terms of DQM

cmsbuild · 2020-01-31T13:54:17Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-01-31T14:13:50Z

+1

mmusich added 3 commits January 29, 2020 20:07

set more meaningful axis range for DistanceOfClosestApproachToBSdz

5015f7c

change the target directory of the Tracking efficiency plots in colli…

69659ca

…sion mode

apparently duplicated file, not included anywhere

3a1efdb

cmsbuild added this to the CMSSW_11_1_X milestone Jan 29, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jan 29, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 29, 2020

cmsbuild added tests-started and removed tests-pending labels Jan 30, 2020

cmsbuild added tests-approved and removed tests-started labels Jan 30, 2020

cmsbuild mentioned this pull request Jan 30, 2020

DQM: Switch to edm::stream for DQMEDAnalyzer #28813

Merged

cmsbuild added comparison-available and removed comparison-pending labels Jan 30, 2020

cmsbuild added the tests-pending label Jan 30, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 30, 2020

cmsbuild added tests-started and removed tests-pending labels Jan 31, 2020

cmsbuild added tests-approved and removed tests-started labels Jan 31, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jan 31, 2020

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 31, 2020

cmsbuild added orp-approved and removed orp-pending labels Jan 31, 2020

cmsbuild merged commit e1e3f94 into cms-sw:master Jan 31, 2020

mmusich mentioned this pull request Feb 3, 2020

Tracking DQM: fix multiple ME bookings for Track Seed Monitoring #28859

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking DQM: miscellaneous fixes #28823

Tracking DQM: miscellaneous fixes #28823

mmusich commented Jan 29, 2020 •

edited

Loading

cmsbuild commented Jan 29, 2020

cmsbuild commented Jan 29, 2020

cmsbuild commented Jan 29, 2020

jfernan2 commented Jan 30, 2020

cmsbuild commented Jan 30, 2020 •

edited

Loading

cmsbuild commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

schneiml commented Jan 30, 2020

mmusich commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

jfernan2 commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

mmusich commented Jan 30, 2020 •

edited

Loading

cmsbuild commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

jfernan2 commented Jan 31, 2020

cmsbuild commented Jan 31, 2020 •

edited

Loading

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

schneiml commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

jfernan2 commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

silviodonato commented Jan 31, 2020

Tracking DQM: miscellaneous fixes #28823

Tracking DQM: miscellaneous fixes #28823

Conversation

mmusich commented Jan 29, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jan 29, 2020

cmsbuild commented Jan 29, 2020

cmsbuild commented Jan 29, 2020

jfernan2 commented Jan 30, 2020

cmsbuild commented Jan 30, 2020 • edited Loading

cmsbuild commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

schneiml commented Jan 30, 2020

mmusich commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

jfernan2 commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

mmusich commented Jan 30, 2020 • edited Loading

cmsbuild commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

jfernan2 commented Jan 31, 2020

cmsbuild commented Jan 31, 2020 • edited Loading

cmsbuild commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

schneiml commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

jfernan2 commented Jan 31, 2020

cmsbuild commented Jan 31, 2020

silviodonato commented Jan 31, 2020

mmusich commented Jan 29, 2020 •

edited

Loading

cmsbuild commented Jan 30, 2020 •

edited

Loading

mmusich commented Jan 30, 2020 •

edited

Loading

cmsbuild commented Jan 31, 2020 •

edited

Loading