-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in Muon Efficiency Maps #23614
Adding in Muon Efficiency Maps #23614
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23614/5236 |
A new Pull Request was created by @ocolegro for master. It involves the following packages: DQM/TrackingMonitor @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 2bd5521 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 2 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
|
||
|
||
edm::Handle<edm::View<reco::Muon> > muons; | ||
iEvent.getByToken(muonToken_,muons); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocolegro please add a check on the validity of the muon collection here, this part may cause issues in the Online clients if the muons are not reconstructed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on the comment by @fioriNTU A prevention is needed please
I am trying to understand the origin of the error. It doesn't seem related to the modifications made by Owen (?). ----- Begin Fatal Exception 19-Jun-2018 06:45:06 CEST----------------------- |
Hi @jandrea , as you can see the error is a timeout - The tests should be realaunched |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23614/5647 |
Pull request #23614 was updated. @andrius-k, @kmaeshima, @schneiml, @dmitrijus, @cmsbuild, @jfernan2 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
It seems to me that this PR is polluting the top level tracking folder |
in addition, may I ask why you are not using the DQMGenericClient for doing the efficiency plots ? |
Adding Muon Efficiency maps to the DQM GUI for fast tracking efficiency studies.