-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Disabled PCA inputs for deepTau v2 (10_6_X) #28046
Conversation
A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_6_X. It involves the following packages: Configuration/Eras @perrotta, @kpedro88, @peruzzim, @cmsbuild, @franzoni, @fgolf, @slava77, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test workflow 1325.51,1329.1,136.772,136.8521 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
backport of #27878 |
+1
|
+1 |
@peruzzim Could you please have a look? Thanks. |
I have tested it for the default configurations without modifiers, and it looks ok |
+xpog |
+operations no change in the main configuration part |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@@ -15,6 +15,14 @@ | |||
cut = cms.string("pt > 18 && tauID('decayModeFindingNewDMs') && (tauID('byLooseCombinedIsolationDeltaBetaCorr3Hits') || tauID('byVLooseIsolationMVArun2v1DBoldDMwLT2015') || tauID('byVLooseIsolationMVArun2v1DBnewDMwLT') || tauID('byVLooseIsolationMVArun2v1DBdR03oldDMwLT') || tauID('byVVLooseIsolationMVArun2v1DBoldDMwLT') || tauID('byVVLooseIsolationMVArun2v1DBoldDMwLT2017v2') || tauID('byVVLooseIsolationMVArun2v1DBnewDMwLT2017v2') || tauID('byVVLooseIsolationMVArun2v1DBdR03oldDMwLT2017v2') || tauID('byVVVLooseDeepTau2017v2VSjet'))") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbluj are we sure this is correct? We are asking for the deepTau bit also in cases where it is not there, e.g. UL2017, and it will crash there, right? I can fix it with the nanoAOD PR, could you please confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeepTauID 2017v2 is contained in MiniAOD of UL2017 as it is now, i.e. w/o planned reMiniAOD, so check for tauID('byVVVLooseDeepTau2017v2VSjet')
is correct.
What concerns planned UL2018/2016 and UL2017 reMiniAOD it will contain DeepTauID 2017v2p1 so this check is modified to tauID('byVVVLooseDeepTau2017v2p1VSjet')
with corresponding era modifiers.
Regardless, I think that matrix tests will fail in case of inconsistent configurations of Mini and NanoAOD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, sorry, I did not read carefully enough and I thought we were asking for 2p1
PR description:
Restore #27882, revert #28032, add fix proposed in #28041 for the failures observed in the IB
PR validation:
See #28041 by @mbluj
Successfully tested with
runTheMatrix.py -l 1325.51,1329.1,136.772,136.8521 -i all --ibeos