Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of era modifiers for DeepTau 2017v2p1 #28041

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Sep 20, 2019

PR description:

This PR fixes issue found in (already merged) #27882 by changing order of era modifiers.
The PR is hopefully directed to correct branch.

PR validation:

Successfully tested with runTheMatrix.py -l 1325.51,1329.1,136.772,136.8521 -i all --ibeos

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for revert-28032-revert-27882-CMSSW_10_6_X_tau-pog_deepTauVetoPCA.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

@mbluj this is now part of #28046

@peruzzim
Copy link
Contributor

this should be closed, right?

@mbluj
Copy link
Contributor Author

mbluj commented Oct 16, 2019

this should be closed, right?

I think so as it was integrated as part of #28046.

@mbluj mbluj closed this Oct 16, 2019
@swozniewski swozniewski deleted the CMSSW_10_6_X_tau-pog_deepTauVetoPCA branch June 19, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants