-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete low pT electron chain (back port) #25887
Complete low pT electron chain (back port) #25887
Conversation
A new Pull Request was created by @bainbrid for CMSSW_10_2_X. It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @perrotta, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@mrodozov |
code-checks |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25887/8356
|
Just a heads up for the future:
We cannot yet define precisely the timescale for the above, so we'd prefer to:
Is this reasonable? |
Hi @bainbrid : yes, that makes sense. We can proceed with this PR as soon as the needed external becomes available in 10_2_X @mrodozov @smuzaffar : could you please prepare a similar PR as cms-sw/cmsdist/pull/4650 for 10_2_X, or arrange with @bainbrid for it, if anything which is needed is missing? Then we can launch the tests here. |
I think there is nothing missing - you can take the existing models used already for 105X. |
cmssw related PR: cms-sw/cmssw#25887
Use cms-sw/cmsdist#4691 to test this when you are rdy. |
please test with cms-sw/cmsdist#4691 |
The tests are being triggered in jenkins. |
backport of #25753 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Hi all - just a gentle ping - is there anything left to do here? |
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR is the back port of #25753.
It relies on cms-sw/cmsdist#4691 (produced for 102X).
In summary, the PR:
The modified existing modules are:
LowPtGsfElectronSeedProducer
: this producer is minimally extended to produce a ValueMap indexed by an ElectronSeedRef. The PreIds hold the discriminator outputs of the BDT models used by this producer but the PreIds cannot be accessed directly from the GsfElectrons and related interfaces, while the ElectronSeeds are accessible. Hence this ValueMap allows theLowPtGsfElectronSeedValueMaps
module to link the BDT output from the Seeding module to electrons, details below.The new modules are:
LowPtGsfElectronSCProducer
: A new "tracker-driven" SuperCluster producer, seeded by extrapolating the low pT GsfTracks and brem trajectories to the ECAL.LowPtGsfElectronCoreProducer
: this straightforward module produces GsfElectronCore objects and borrows heavily from the standard EGamma code.LowPtGsfElectronProducer
: this straightforward module produces GsfElectron objects and borrows heavily from the standard EGamma code.lowPtGsfElectronSeedValueMapsProducer
: This module consumes GsfElectrons and the ValueMap from theLowPtGsfElectronSeedProducer
module. It produces two ValueMap indexed by a GsfElectronRef that contain the BDT discriminator values.LowPtGsfElectronIDProducer
: this module consumes GsfElectrons and makes use of a BDT model to ID the electrons, i.e. discriminate genuine electrons from fakes. The XML description of the model can be found in this PR to the cms-data repository.miniAOD
integration: modifications to thePhysicsTools/PatAlgos
package allow to produced a slimmed low pT electron collection.Here is the new sequence.
Here are the output collections stored for the RECO and AOD data tiers.
Here and here are the collections stored in the miniAOD data tier.