Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MVA ID for low pT ele based on 94X MC #12

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

bainbrid
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bainbrid for branch master.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#4648

@bainbrid bainbrid reopened this Jan 17, 2019
@bainbrid
Copy link
Contributor Author

This PR adds a new BDT model used in the ID module for an upcoming PR that completes the low pT electron reconstruction.

@mverzett - please can you the relevant ROC curve demonstrating the models performance, and perhaps some further detail?

The model is identical to the one used by EGamma "MVA ID" but has been retrained using B->K(*)ee MC samples generated with 9_4_X.

This model, along with the two BDT models included as part of this closed PR and used by the Seeding module, will be updated in due course with trainings based on 10_2_X MC samples.

@slava77 @perrotta

@bainbrid
Copy link
Contributor Author

The cms-sw#25696 PR relies on the model in this PR.

@mrodozov
Copy link
Contributor

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@bainbrid
Copy link
Contributor Author

8bb2fd154ffbbbfa05c478056e244ee64b257fcfa037376e8f1e309a03919549

The model is identical to the one used by EGamma "MVA ID" but has been retrained using B->K(*)ee MC samples generated with 9_4_X.

@perrotta
Copy link

+1
(Could a cmsdist PR be made out of this, so that tests for #25696 can be run?)

@mrodozov
Copy link
Contributor

+externals
for bookkeeping

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

@bainbrid
Copy link
Contributor Author

bainbrid commented Feb 4, 2019

hi - has this PR integrated into the master IBs? I don't see the new file e.g. here:
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_5_X_2019-02-04-1100/external/slc6_amd64_gcc700/data/RecoEgamma/ElectronIdentification/data/LowPtElectrons/RunII_Fall17_LowPtElectrons_mva_id.xml.gz

@smuzaffar
Copy link
Contributor

@bainbrid , this is not yet merged in cmssw. Both CMSSW pr and cmsdist PR are still open. Once the following two PR are merged then this new files will be avialable.
cms-sw/cmsdist#4650
cms-sw/cmssw#25753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants