Implement second HF min-bias feature bit

[christopheralanwest]

Only a single min-bias trigger has been used for 2018 pp running. For the upcoming 2018 HI run, two min-bias triggers that have different thresholds, but are otherwise identical, have been requested.

This PR implements two changes:

• The code changes needed to generate LUTs for the HCAL trigger that configure the second HF min-bias feature bit. This code has already been used to generate LUTs that have been used online for the HI test runs.
• For the pp_on_AA_2018 era, the HF trigger primitive simulation has been modified to generate two min-bias feature bits with thresholds of >15 and >19 ADC counts for the existing and new ("second") feature bit. These thresholds are similar to those that are expected to be used during the 2018 HI run. No changes are expected for any other era.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24847/6808

[cmsbuild]

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos
CalibCalorimetry/HcalTPGEventSetup
CaloOnlineTools/HcalOnlineDb
SimCalorimetry/HcalTrigPrimAlgos
SimCalorimetry/HcalTrigPrimProducers

@cmsbuild, @tocheng, @nsmith-, @rekovic, @franzoni, @thomreis, @ggovi, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30998/console Started: 2018/10/12 01:08

[cmsbuild]

-1

Tested at: 54853ef

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24847/30998/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation warning when building: See details on the summary page.

• Clang:

I found compilation warning while trying to compile with clang:
I used this command:
USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'
See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

+1
Tested at: 08444b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24847/31014/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24847/31014/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994723
• DQMHistoTests: Total failures: 176
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994350
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[christopheralanwest]

The expected effect of this PR is seen in the HI workflow 158.0. hcalOccSentFb and hcalOccRecdFb now have entries, corresponding to the new feature bit, and hcalOccSentFb2 and hcalOccRecdFb2 have more entries, a consequence of the lowered threshold for this bit in HI workflows.

I don't understand the changes in data/emulation comparisons for taus, which should be unaffected by any sort of change in HF. The backport of this PR (#24857) sees changes in electrons rather than taus, adding to the confusion. These changes seem unrelated to this PR.

[fabiocos]

@christopheralanwest thank you for your feedback, I am afraid the issue with taus is the same that we have already seen in previous PRs, and related to a non reproducibility of part of the L1T emulator/DQM chain, that should be fixed asap

[rekovic]

+1

[ggovi]

+1

[lpernie]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1