Complete HE depth feature bit implementation

[christopheralanwest]

This PR implements code changes needed to implement depth feature bits [1] into HE trigger primitives. The changes are as follows:

• Generation of HE depth feature bit LUTs for use online (5a23ad7, 5a9be22, c42032b)
• Do not apply peak finding to feature bits, to match the firmware behavior (as a primary use of the depth feature bit algorithm is MIP detection, peak detection would be very noisy); Fix of indexing issues to reflect that depth indexing starts at 1, not 0 (8ff026a)
• Addition of new algorithms used for technical tests of the generation of the feature bits (9d50b6d)
• Update to LUT generation configuration and a technical change to the formatting of some of the XML tags in the LUTs (68f7bcc, 8b13429) to reflect what is currently in use. This is not logically directly related to other commits but is needed more generally for LUT generation. These changes are already in use.

The feature bit code has been tested at 904 using uHTRs that read out only HE [2] and gives perfect agreement between data and emulation. As mentioned at [2], the online software does not yet support the loading of HE feature bit LUTs in uHTRs that read out both HB and HE and so data/emulation comparisons have not been performed for the highest and lowest ieta ranges of HE. I have verified that the LUTs are nevertheless generated for these towers, even though they are not currently used. Since all towers in HE have identical LUTs, no further changes will be needed for the mixed HB/HE readout.

The only changes in PR comparison tests will appear in the feature bits of the HE trigger primitives, in samples that contain an upgraded HE. As these feature bits are not yet used by any downstream quantity, no physical quantity will change.

[1] for details, see pages 23-25 of https://cms-docdb.cern.ch/cgi-bin/DocDB/ShowDocument?docid=12306
[2] http://cmsonline.cern.ch/cms-elog/1063064

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24556/6436

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24556/6436/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24556/6436/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24556/6437

[cmsbuild]

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos
CaloOnlineTools/HcalOnlineDb
SimCalorimetry/HcalTrigPrimAlgos

@cmsbuild, @tocheng, @nsmith-, @rekovic, @franzoni, @thomreis, @ggovi, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30434/console Started: 2018/09/16 18:50

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31102/console Started: 2018/10/17 15:45

[cmsbuild]

+1
Tested at: 6bb7122
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24556/31102/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6bb7122
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24556/31102/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24556/31102/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24556/31102/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 28
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994618
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[christopheralanwest]

The pattern of changes in the comparison tests is the same as in my summary from September 17. No commits that could introduce any change in the behavior of this PR have been introduced since that time.

[christopheralanwest]

@rekovic , @thomreis , @nsmith- Could you take a look at this PR? Thanks.

[thomreis]

+1

[fabiocos]

@lpernie @tocheng @ggovi could you please scrutinize this PR?

[ggovi]

+1

[christopheralanwest]

@lpernie @tocheng There have been no changes to AlCa-related packages since you last signed off on this PR.

[fabiocos]

+1

[fabiocos]

merge

AlCa had already signed, the latest update does not look to affect their part