-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate SiStripGainsPCLWorker to concurrent and global DQM #22515
Migrate SiStripGainsPCLWorker to concurrent and global DQM #22515
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22515/3819 |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CalibTracker/SiStripChannelGain @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Greetings,
I am re-proposing #22320 with a clean git history this time, and some further cleaning.
The purpose of ec655a6 remains the same, moving the "worker" step of the SiStrip gains PCL workflow to concurrent and global DQM.
The advantage in terms of memory consumption, after the migration to
edm::one
of theDQMEDAnalyzer
, of running step3 ofrunTheMatrix.py -l 1001.0 -t 4
is reduced, but still visible.The other advantage I can see is that if running (in standalone mode) the Gain Calibration in a plain
CMSSW_10_1_0_pre2
(in single-threaded mode) via:cmsDriver.py step3 --datatier ALCARECO --conditions auto:run2_data -s ALCA:PromptCalibProdSiStripGains --eventcontent ALCARECO -n 100 --dasquery='file dataset=/ZeroBias/Run2016C-SiStripCalMinBias-18Apr2017-v1/ALCARECO run=276097'
followed by:
one receives a segmentation fault (stack is available here ), while this PR changes this is not the case.
Running the step3 in MT mode even in
CMSSW_10_1_0_pre2
with:cmsDriver.py step3 --datatier ALCARECO --conditions auto:run2_data -s ALCA:PromptCalibProdSiStripGains --eventcontent ALCARECO -n 100 --dasquery='file dataset=/ZeroBias/Run2016C-SiStripCalMinBias-18Apr2017-v1/ALCARECO run=276097' --nThreads 4
doesn't produce a segfault.
I profit of this PR to update the unit test with the standalone harvester step to be run in sequence after the Analyzer step in 5fa99ec.
As a final note to the reviewers no algorithmic change is intended by this PR, so both calibration output and monitoring plots shall remain the same. This is validated cross-checking the outputs of running the workflow on 1000 events of run 276097 here.