Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SiStripGainsPCLWorker to concurrent and global DQM #22515

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 7, 2018

Greetings,
I am re-proposing #22320 with a clean git history this time, and some further cleaning.
The purpose of ec655a6 remains the same, moving the "worker" step of the SiStrip gains PCL workflow to concurrent and global DQM.
The advantage in terms of memory consumption, after the migration to edm::one of the DQMEDAnalyzer, of running step3 of runTheMatrix.py -l 1001.0 -t 4 is reduced, but still visible.
image
The other advantage I can see is that if running (in standalone mode) the Gain Calibration in a plain CMSSW_10_1_0_pre2 (in single-threaded mode) via:

cmsDriver.py step3 --datatier ALCARECO --conditions auto:run2_data -s ALCA:PromptCalibProdSiStripGains --eventcontent ALCARECO -n 100 --dasquery='file dataset=/ZeroBias/Run2016C-SiStripCalMinBias-18Apr2017-v1/ALCARECO run=276097'

followed by:

cmsDriver.py stepHarvest --data --conditions auto:run2_data --scenario pp -s ALCAHARVEST:SiStripGains --filein file:PromptCalibProdSiStripGains.root -n 100 --fileout file:calib.root

one receives a segmentation fault (stack is available here ), while this PR changes this is not the case.
Running the step3 in MT mode even in CMSSW_10_1_0_pre2 with:

cmsDriver.py step3 --datatier ALCARECO --conditions auto:run2_data -s ALCA:PromptCalibProdSiStripGains --eventcontent ALCARECO -n 100 --dasquery='file dataset=/ZeroBias/Run2016C-SiStripCalMinBias-18Apr2017-v1/ALCARECO run=276097' --nThreads 4

doesn't produce a segfault.
I profit of this PR to update the unit test with the standalone harvester step to be run in sequence after the Analyzer step in 5fa99ec.
As a final note to the reviewers no algorithmic change is intended by this PR, so both calibration output and monitoring plots shall remain the same. This is validated cross-checking the outputs of running the workflow on 1000 events of run 276097 here.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripChannelGain

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @gbenelli, @tocheng, @jlagram, @OlivierBondu, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26665/console Started: 2018/03/07 18:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22515/26665/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2480211
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2480034
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.969999999928 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Mar 13, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e92a013 into cms-sw:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants