Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Migrate SiStripGainsPCLWorker to concurrent and global DQM #22320

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 23, 2018

In an attempt to solve the issue in #22281, I've tried to migrate SiStripGainsPCLWorker from DQMEDAnalyzer to DQMGlobalEDAnalyzer.
Will probably push more commits to clean the code (and I would also like to make some more extended tests), but comments are already welcome.
Running in a CMSSW_10_1_X_2018-02-21-2300, the command runTheMatrix.py -l 1001.0 -t 4 --ibeos runs to completion, at variance with the vanilla IB which is segfaulting at step8.
Incidentally, I've measured the decrease of RSS memory consumption of step3 of runTheMatrix.py -l 1001.0 -t 4 and looks sizable (barring errors on my side)
image

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3529

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3529/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3529/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3530

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3530/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3530/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripChannelGain

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @gbenelli, @tocheng, @jlagram, @OlivierBondu, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26274/console Started: 2018/02/23 18:45

@cmsbuild
Copy link
Contributor

@lpernie
Copy link
Contributor

lpernie commented Feb 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

The code-checks are being triggered in jenkins.

@mmusich mmusich closed this Mar 1, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

Pull request #22320 was updated. @ghellwig, @vazzolini, @kmaeshima, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @franzoni, @jfernan2, @vanbesien, @lpernie can you please check and sign again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants