-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Migrate SiStripGainsPCLWorker to concurrent and global DQM #22320
RFC: Migrate SiStripGainsPCLWorker to concurrent and global DQM #22320
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3529 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3529/git-diff.patch You can run |
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3530 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3530/git-diff.patch You can run |
b3767cd
to
fa9cf97
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3531 |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CalibTracker/SiStripChannelGain @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
51793f4
to
3a49e5d
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22320/3629 |
Pull request #22320 was updated. @ghellwig, @vazzolini, @kmaeshima, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @franzoni, @jfernan2, @vanbesien, @lpernie can you please check and sign again. |
In an attempt to solve the issue in #22281, I've tried to migrate
SiStripGainsPCLWorker
fromDQMEDAnalyzer
toDQMGlobalEDAnalyzer
.Will probably push more commits to clean the code (and I would also like to make some more extended tests), but comments are already welcome.
Running in a
CMSSW_10_1_X_2018-02-21-2300
, the commandrunTheMatrix.py -l 1001.0 -t 4 --ibeos
runs to completion, at variance with the vanilla IB which is segfaulting at step8.Incidentally, I've measured the decrease of RSS memory consumption of step3 of
runTheMatrix.py -l 1001.0 -t 4
and looks sizable (barring errors on my side)