Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[92x] L1T EMTF 2017 Full #20768

Closed

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Oct 6, 2017

92X - rebased 94x EMTF PRs #19743 #20006 #20286

Once the tests pass with the inital PR:

There are a few other things related to EMTF
which are already merged to integration branch
that I should add on top the currently testing PR,
but for now, I want to make sure this one passes.

Things to add later:

  • v96.14
    EMTF Remove include of depricated header file in Online producer that
    was causing problem to HLT with git cms-checkdeps -A -a .

  • v96.21
    EMTF: value-initialise EMTFPtLUT variables before use (13 TeV mc relvals pre8 re cycle 70x gf1 #595)

  • v96.28
    EMTF water leak fix and 2016 / 17 conditions configurations via
    hackConditions (Merge from CVS HEAD. #604).

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20768/23509/summary.html

Comparison Summary:

  • You potentially added 4055 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1966573
  • DQMHistoTests: Total failures: 15718
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 1950679
  • DQMHistoTests: Total skipped: 172
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 9 edm output root files, 23 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Oct 7, 2017

+1

The above mentioned commits from l1t-integration branch are already part of 94x version and part of this 92x rebased version, by construction.

@dmitrijus
Copy link
Contributor

+1

@ggovi
Copy link
Contributor

ggovi commented Oct 10, 2017

+1

@ghellwig
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@rekovic
Copy link
Contributor Author

rekovic commented Oct 17, 2017

@davidlange6 please merge this one

@davidlange6
Copy link
Contributor

CMSSW_9_2_X developement work is completed. Closing remaining PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants