-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMTF 2017 PR #2 - 2017 DataFormats #19743
Conversation
A new Pull Request was created by @abrinke1 for master. It involves the following packages: DQM/L1TMonitor @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
oops, |
No it should be fine. The commit from #19741seems to be also in this PR. |
Of course, it could be merged on its own, skipping #19741. That's up to @davidlange6 et. al., I suppose. The PRs are split up for convenience in reviewing different commits, but they are all sequential. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
Pull request #19743 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
@davidlange6, @smuzaffar @rekovic Requested changes committed. |
please test |
The tests are being triggered in jenkins. |
Pull request #19743 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
merge |
Thanks, @davidlange6 ! |
Part 2 of set of PRs following PR #19741
Updated EMTF internal data formats for 2017, primarily adding info for RPCs, and adding new formats ("EMTFRoad") and functionalities for the upgraded EMTF emulator.
Temporarily have both 2016 and 2017 data formats at the same time, so some old and some new EMTF modules (in the intermediate PRs) can run at the same time.
Updated EMTF unpacker including several major improvements:
Still outputs empty collections of EMTFHit2016 and EMTFTrack2016 so we don't break the DQM sequences.
Changes grouped as follows:
DataFormats/L1TMuon/interface/EMTF/*.h
EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockX.cc
EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockX.h
L1Trigger/L1TMuonEndCap/interface/TrackTools.X