Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing virtual dtors #2 #18273

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Add missing virtual dtors #2 #18273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CalibFormats/CastorObjects/interface/CastorCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class CastorCoder {
public:
virtual void adc2fC(const CastorDataFrame& df, CaloSamples& lf) const = 0;
virtual void fC2adc(const CaloSamples& clf, CastorDataFrame& df, int fCapIdOffset) const = 0;
virtual ~CastorCoder() = default;
};

#endif
1 change: 1 addition & 0 deletions CalibFormats/HcalObjects/interface/HcalCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class HcalCoder {
virtual void fC2adc(const CaloSamples& clf, HcalCalibDataFrame& df, int fCapIdOffset) const = 0;
virtual void fC2adc(const CaloSamples& clf, QIE10DataFrame& df, int fCapIdOffset) const = 0;
virtual void fC2adc(const CaloSamples& clf, QIE11DataFrame& df, int fCapIdOffset) const = 0;
virtual ~HcalCoder() = default;
};

#endif
1 change: 1 addition & 0 deletions EventFilter/L1TRawToDigi/interface/Packer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ namespace l1t {
class Packer {
public:
virtual Blocks pack(const edm::Event&, const PackerTokens*) = 0;
virtual ~Packer() = default;
};

typedef std::vector<std::shared_ptr<Packer>> Packers;
Expand Down
2 changes: 2 additions & 0 deletions EventFilter/L1TRawToDigi/interface/PackerTokens.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ namespace edm {

namespace l1t {
class PackerTokens {
public:
virtual ~PackerTokens() = default;
};
}

Expand Down
3 changes: 0 additions & 3 deletions L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,6 @@ CSCMotherboard::CSCMotherboard() :
}
}

CSCMotherboard::~CSCMotherboard() {
}

void CSCMotherboard::clear() {
if (alct) alct->clear();
if (clct) clct->clear();
Expand Down
2 changes: 1 addition & 1 deletion L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class CSCMotherboard
CSCMotherboard();

/** Default destructor. */
~CSCMotherboard();
virtual ~CSCMotherboard() = default;

/** Test version of run function. */
void run(const std::vector<int> w_time[CSCConstants::NUM_LAYERS][CSCConstants::MAX_NUM_WIRES],
Expand Down
1 change: 1 addition & 0 deletions RecoEgamma/EgammaHLTProducers/interface/HLTCaloObjInRegionsProducer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class EtaPhiRegion{
class EtaPhiRegionDataBase {
public:
EtaPhiRegionDataBase(){}
virtual ~EtaPhiRegionDataBase() = default;
virtual void getEtaPhiRegions(const edm::Event&,std::vector<EtaPhiRegion>&)const=0;
};

Expand Down