-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing virtual dtors #2 #18273
Add missing virtual dtors #2 #18273
Conversation
CMSSW GCC 7.0.1 builds now follows jemalloc (dev branch) and also has a new TCMalloc. Both of these have C++14 sized deallocation feature enabled. This means that if possible operator delete will be called with size argument, which will help allocator to reduce the time to free the object. E.g. this is not possible for incomplete types which size is unknown at a time. GCC 7.0.1 builds contain an additional build of jemalloc (jemalloc-debug) which contains extra asserts and checks for developers. This seems to be undefined behavior in C++14. From [expr.delete] (5.3.5 Delete): In the first alternative (delete object), if the static type of the object to be deleted is different from its dynamic type, the static type shall be a base class of the dynamic type of the object to be deleted and the static type shall have a virtual destructor or the behavior is undefined. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for master. It involves the following packages: CalibFormats/CastorObjects @ghellwig, @cmsbuild, @silviodonato, @arunhep, @cerminar, @Martin-Grunewald, @rekovic, @franzoni, @fwyzard, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
CMSSW GCC 7.0.1 builds now follows jemalloc (dev branch) and also has a
new TCMalloc. Both of these have C++14 sized deallocation feature
enabled. This means that if possible operator delete will be called with
size argument, which will help allocator to reduce the time to free the
object. E.g. this is not possible for incomplete types which size is
unknown at a time.
GCC 7.0.1 builds contain an additional build of jemalloc
(jemalloc-debug) which contains extra asserts and checks for developers.
This seems to be undefined behavior in C++14. From [expr.delete] (5.3.5
Delete):
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch