80x re-miniAOD

[andrewj314]

Rework of PR #12586 to run over 80X. This PR includes new anti-electron discriminators with updated MVA training (MVA6) from Fabio as well as updated MVA training for new ID discriminators from Arun. There are also some minor fixes (additional keep statements in RecoTauTag/Configuration/python/RecoTauTag_EventContent_cff.py that were causing matrix tests to throw missing module exceptions). This PR is for taus only.

Comparison plots can be found here:
https://ytakahas.web.cern.ch/ytakahas/validation_20151201/

Note: this is now working in 8_0_0_pre4. We expect the compilation issues we ran into as well as those we ran into with poison libraries were not due to issues with tau code but with the 8_0_X version used.

[cmsbuild]

A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos
RecoTauTag/Configuration
Validation/RecoTau

@cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@andrewj314
please update the PR subject to be more descriptive (the current one is just wrong)

From a quick look, it seems like your are adding quite a few more discriminants.
I'm expecting that in 80X we do not keep old and outdated discriminants.
Were the old ones properly cleaned up in this PR?

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10692/console

[cmsbuild]

-1

Tested at: ce05e34
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13042/10692/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13042/10692/summary.html

[slava77]

in the unit tests in PhysicsTools/PatAlgos/test/runtests.sh I see

   [4] Calling produce method for unscheduled module PATTauProducer/'patTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: reco::PFTauDiscriminator
Looking for module label: hpsPFTauDiscriminationByMVA6LooseElectronRejection

Is this a new discriminant?
One way out is to not use the new discriminants in PAT until they make it to AOD (next relval cycle).

[slava77]

should this be closed?

[slava77]

-1
superseded by #13060