76x re mini aod #12586
Merged
76x re mini aod #12586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new MVA ID
…/cmssw into 76xNewDiscriminators
add new MVA discriminators to event content
…on from MVA5 to MVA6) and changed db from CMS_COND_PAT_000 to CMS_CONDITIONS
…on from MVA5 to MVA6) and changed db from CMS_COND_PAT_000 to CMS_CONDITIONS
…uration/python/loadRecoTauTagMVAsFromPrepDB_cfi.py
…auTag/Configuration/python/loadRecoTauTagMVAsFromPrepDB_cfi.py
Conflicts: RecoTauTag/Configuration/python/loadRecoTauTagMVAsFromPrepDB_cfi.py
…/cmssw into 76xNewDiscriminators
Updates for 76X reminiAOD
…inators for reminiAOD v2 processing
…clude statements in PFRecoTauClusterVariables.h, switching from TMath to std in PFRecoTauDiscriminationByIsolationRun2.cc
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
| * | ||
| */ | ||
|
|
||
| using namespace reco; |
There was a problem hiding this comment.
still here.
Not allowed in header files.
Removing namespace reco from the header file. This had 0 effect on the compilation (which is mildly surprising)
|
@slava77 , @andrewj314 , @cvuosalo I took the liberty to do the last change. I compiled locally and found no issue with this change. I am currently running matrix tests to be completely sure. In the mean time could someone also trigger the tests? Thanks! @slava77 If you could please let us know if you know of anymore pending issues it would be appreciated. |
|
@cmsbuild please test |
|
I tried trigger the tests but not sure if it will work... |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1
@andrewj314 please post some validation slides or a link to them |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of PR #12298 to run over 76X. This PR includes new anti-electron discriminators with updated MVA training (MVA6) from Fabio as well as updated MVA training for new ID discriminators from Arun. There are also some minor fixes (additional keep statements in RecoTauTag/Configuration/python/RecoTauTag_EventContent_cff.py that were causing matrix tests to throw missing module exceptions). This PR is for taus only.
Comparison plots can be found here:
https://ytakahas.web.cern.ch/ytakahas/validation_20151201/