Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter VID tools to check for already existing ID Definitions when being switched on (75X) #10525

Merged
merged 1 commit into from
Aug 6, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 3, 2015

Forward port of #10434

@lgray
Copy link
Contributor Author

lgray commented Aug 3, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 3, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Alter VID tools to check for already existing ID Definitions when being switched on

It involves the following packages:

PhysicsTools/SelectorUtils

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

-1
Tested at: 5d340af
When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10525/6914/summary.html

@lgray
Copy link
Contributor Author

lgray commented Aug 4, 2015

ok... tests died here... resubmitting...

@lgray
Copy link
Contributor Author

lgray commented Aug 4, 2015

@cmsbuild please test

@lgray
Copy link
Contributor Author

lgray commented Aug 4, 2015

hmmm...

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@monttj
Copy link
Contributor

monttj commented Aug 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@lgray lgray changed the title Alter VID tools to check for already existing ID Definitions when being switched on Alter VID tools to check for already existing ID Definitions when being switched on (75X) Aug 5, 2015
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 6, 2015
Alter VID tools to check for already existing ID Definitions when being switched on (75X)
@cmsbuild cmsbuild merged commit 9be7629 into cms-sw:CMSSW_7_5_X Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants