Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter VID tools to check for already existing ID Definitions when being switched on #10434

Merged
merged 1 commit into from
Aug 1, 2015
Merged

Alter VID tools to check for already existing ID Definitions when being switched on #10434

merged 1 commit into from
Aug 1, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 28, 2015

Fix for the problems reports in HN:
https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3239.html

This fix has uncovered further problems in expanding RECO + MiniAOD configurations...

@franzoni @davidlange6

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jul 28, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

Change cmsDriver such that it does not run things in config file twice

It involves the following packages:

Configuration/Applications

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor Author

lgray commented Jul 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 16aacb1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10434/5815/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10434/5815/summary.html

@lgray
Copy link
Contributor Author

lgray commented Jul 29, 2015

@franzoni @davidlange6 I can't seem to find the root of what is keeping egmGsfElectronIDs as a global variable. Leaving this PR as is for now.

@lgray lgray changed the title Change cmsDriver such that it does not run things in config file twice Alter VID tools to check for already existing ID Definitions when being switched on Jul 30, 2015
@cmsbuild
Copy link
Contributor

Pull request #10434 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

davidlange6 added a commit that referenced this pull request Aug 1, 2015
@davidlange6
Merge pull request #10434 from lgray/patch_cmsDriver
37aba16 
Alter VID tools to check for already existing ID Definitions when being switched on
@davidlange6 davidlange6 merged commit 37aba16 into cms-sw:CMSSW_7_4_X Aug 1, 2015
@lgray lgray mentioned this pull request Aug 3, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
3 participants
@lgray @cmsbuild @davidlange6