-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace bunch of debug-ifdefs in MultiHitGeneratorFromChi2 with a macro #10305
Replace bunch of debug-ifdefs in MultiHitGeneratorFromChi2 with a macro #10305
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X. Replace bunch of debug-ifdefs in MultiHitGeneratorFromChi2 with a macro It involves the following packages: RecoTracker/TkSeedGenerator @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Replace bunch of debug-ifdefs in MultiHitGeneratorFromChi2 with a macro
This PR attempts to address @slava77's comment #10231 (comment) on the debug-ifdefs introduced in #10231. Most of the ifdefs are replaced with a new, locally-defined macro
IfLogTrace
, that has different definition depending ifEDM_ML_DEBUG
is defined or not.Tested in CMSSW_7_6_X_2015-07-21-1100, no changes expected in results.
@rovere @VinInn