-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform couts to LogDebug/LogTrace in MultiHitGeneratorFromChi2 #10231
Transform couts to LogDebug/LogTrace in MultiHitGeneratorFromChi2 #10231
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X. Transform couts to LogDebug/LogTrace in MultiHitGeneratorFromChi2 It involves the following packages: RecoTracker/ConversionSeedGenerators @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@slava77 Fully agree on the ifdefs (they just were the simplest-to-write solution to preserve existing debug-print behaviour). Thinking now, probably with some macro(s) the ifdefs could be removed from the function bodies, I could give a try if deemed useful. |
+1 |
Transform couts to LogDebug/LogTrace in MultiHitGeneratorFromChi2
Following @cvuosalo's comment #10016 (comment), this PR transforms all couts in MultiHitGeneratorFromChi2 to LogDebug/LogTrace. In order to be able to compile with
-DEDM_ML_DEBUG
, I had to first fix bunch of errors within LogDebugs in Conv4HitsReco.Tested in CMSSW_7_6_X_2015-07-10-1100, no changes expected in results.
@rovere @VinInn