Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cepgen] Disable BoostWrapper addon #9323

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jul 26, 2024

We were not building CepGen BoostWrapper as our containers (cmssw-elX) do not have boost installed on system (we always want to use boost from cms externals). But on systems with boost is installed (and where we can not use our containers e.g. riscv) cepgen picks up Boost from system and then packaging fail as it complains about wrong boost_system lib dependency.

Somehow I was not able to convince cepgen build system to use our boost (may be we are missing something in our boost?) so for now we explicitly disable cepgen BoostWrapper

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 26, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

FYI @forthommel

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 1016602 into IB/CMSSW_14_1_X/master Jul 26, 2024
6 of 9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d9900/40636/summary.html
COMMIT: a0404f7
CMSSW: CMSSW_14_1_X_2024-07-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9323/40636/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d9900/40636/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d9900/40636/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3631 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3312343
  • DQMHistoTests: Total failures: 16464
  • DQMHistoTests: Total nulls: 88
  • DQMHistoTests: Total successes: 3295771
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 61.702000000000005 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 8.774 KiB HLT/Filters
  • DQMHistoSizes: changed ( 12834.0,... ): 0.070 KiB HLT/TAU
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: found differences in 7 / 42 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants