Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for RISC-V #9314

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Changes for RISC-V #9314

merged 3 commits into from
Jul 25, 2024

Conversation

iarspider
Copy link
Contributor

  • libzmq: add explicit dependency on libunwind
  • matplotlib: explicitly ask to use system freetype, i.e. not build it from source
  • ROOT: update config.{sub,guess} for libAfterImage
  • openmpi: explicitly configure to build it's own version of pmix (no version is installed on x86/arm machines, the version installed on RISC-V is not accepted because it's built with wrong libevent?)

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a25d3/40551/summary.html
COMMIT: adce483
CMSSW: CMSSW_14_1_X_2024-07-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9314/40551/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@iarspider
Copy link
Contributor Author

iarspider commented Jul 24, 2024

please test for el8_aarch64_gcc12

@iarspider
Copy link
Contributor Author

please test for slc7_amd64_gcc12

@iarspider
Copy link
Contributor Author

please test for el9_amd64_gcc12

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a25d3/40570/summary.html
COMMIT: adce483
CMSSW: CMSSW_14_1_X_2024-07-23-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9314/40570/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a25d3/40572/summary.html
COMMIT: adce483
CMSSW: CMSSW_14_1_X_2024-07-23-2300/el9_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9314/40572/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1287 lines to the logs
  • Reco comparison results: 56002 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3325254
  • DQMHistoTests: Total failures: 352181
  • DQMHistoTests: Total nulls: 278
  • DQMHistoTests: Total successes: 2972775
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.22399999999999998 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.192 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -0.255 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.048 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.719 KiB SiStrip/MechanicalView
  • Checked 191 log files, 161 edm output root files, 44 DQM output files

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a25d3/40571/summary.html
COMMIT: adce483
CMSSW: CMSSW_14_1_X_2024-07-23-2300/slc7_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9314/40571/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestHeterogeneousCoreSonicTritonProducerCPU had ERRORS
---> test DRNTest had ERRORS

Comparison Summary

Summary:

  • You potentially added 922 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 61640 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3325254
  • DQMHistoTests: Total failures: 217565
  • DQMHistoTests: Total nulls: 312
  • DQMHistoTests: Total successes: 3107357
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.093 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 13034.0 ): 1.523 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.035 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.059 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.660 KiB SiStrip/MechanicalView
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: found differences in 14 / 42 workflows

libzmq.spec Outdated
@@ -3,6 +3,7 @@
%define tag 5bf04ee2ff207f0eaf34298658fe354ea61e1839
Source: git+https://github.com/zeromq/libzmq.git?obj=%{branch}/%{tag}&export=%{n}-%{realversion}&output=/%{n}-%{realversion}.tgz
BuildRequires: autotools
Requires: libunwind
Copy link
Contributor

@smuzaffar smuzaffar Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iarspider , I think better to use --enable-libunwind=no configure option

@cmsbuild
Copy link
Contributor

Pull request #9314 was updated.

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 4e6b81a into IB/CMSSW_14_1_X/master Jul 25, 2024
4 of 5 checks passed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a25d3/40620/summary.html
COMMIT: 76c0887
CMSSW: CMSSW_14_1_X_2024-07-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9314/40620/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a25d3/40620/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a25d3/40620/git-merge-result

Comparison Summary

Summary:

  • You potentially added 25 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 169 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3312343
  • DQMHistoTests: Total failures: 14681
  • DQMHistoTests: Total nulls: 14
  • DQMHistoTests: Total successes: 3297628
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 61.702000000000005 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 8.774 KiB HLT/Filters
  • DQMHistoSizes: changed ( 12834.0,... ): 0.070 KiB HLT/TAU
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: found differences in 6 / 42 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants