Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for CalibPPS-ESProducers to V01-04-00 #7282

Merged

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Sep 8, 2021

Move CalibPPS-ESProducers data to new tag, see
cms-data/CalibPPS-ESProducers#5

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Sep 8, 2021

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@tvami
Copy link

tvami commented Sep 8, 2021

Hi @mrodozov just for my education, what does V01-04-00 encode?

@tvami
Copy link

tvami commented Sep 8, 2021

@cmsbuild , please test

@mrodozov
Copy link
Contributor

mrodozov commented Sep 8, 2021

for every merged cms-data PR, we make a new tag after it's merged
this is the tag id(number) that is created.
when we change the version here we are switching from the old tag to the new one
in this case from V01-03-00 to V01-04-00

where V01-04-00 is V01-03-00 + cms-data/CalibPPS-ESProducers#5 changes

https://github.com/cms-data/CalibPPS-ESProducers/tags

@tvami
Copy link

tvami commented Sep 8, 2021

for every merged cms-data PR, we make a new tag after it's merged
this is the tag id(number) that is created.
when we change the version here we are switching from the old tag to the new one
in this case from V01-03-00 to V01-04-00

where V01-04-00 is V01-03-00 + cms-data/CalibPPS-ESProducers#5 changes

https://github.com/cms-data/CalibPPS-ESProducers/tags

thanks @mrodozov !

@mrodozov
Copy link
Contributor

mrodozov commented Sep 8, 2021

in this particular case the change will just add the new files from the PR and all will be tested which doesn't change anything and just adds few files. thats why this PR will go fine but it wont test anything. to test it with the cmssw pr - which was already done, use please test with cms-sw/cmssw#35177

since most of the data PRs are already tested against their relevant cms-sw changes, this cmsdist PRs are only "making the change for the release" and thats why we (mostly) don't test them

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Sep 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c4a30/18394/summary.html
COMMIT: 37efff4
CMSSW: CMSSW_12_1_X_2021-09-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7282/18394/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3000973
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Sep 9, 2021

+1

@qliphy
Copy link
Contributor

qliphy commented Sep 9, 2021

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants