Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the pixel local reconstruction code #593

Merged
merged 40 commits into from
Dec 18, 2020
Merged

Clean up the pixel local reconstruction code #593

merged 40 commits into from
Dec 18, 2020

Commits on Dec 15, 2020

  1. Simple cleanup

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    f17d75c View commit details
    Browse the repository at this point in the history

  2. Rename gpuClusteringConstants to lowercase

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    115a591 View commit details
    Browse the repository at this point in the history

  3. Use member initializer list in the constructor

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    c962e79 View commit details
    Browse the repository at this point in the history

  4. Drop TrackingRecHit2DCUDA.h compatibility header

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    2316401 View commit details
    Browse the repository at this point in the history

  5. Allow "if constexpr" in CUDA code

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    e682d25 View commit details
    Browse the repository at this point in the history

  6. Update comment about m_averageGeometry ownership

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    ceb57cd View commit details
    Browse the repository at this point in the history

  7. Recover missing changes from cms-sw#29805

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    da59043 View commit details
    Browse the repository at this point in the history

  8. Cleanup SiPixelGainCalibrationForHLTGPU 

    Code clean up:
  - simplify the constructor;
  - replace commented out messages with LogDebug;
  - delete commented out code.
    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    fca2278 View commit details
    Browse the repository at this point in the history

  9. Rename variables according to the coding rules

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    089d20c View commit details
    Browse the repository at this point in the history

  10. Move to LogDebug and other clean up

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    e307ae2 View commit details
    Browse the repository at this point in the history

  11. Rename variables according to the coding rules

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    c6b266b View commit details
    Browse the repository at this point in the history

  12. Reorder parameters in the autogenerated cfi file

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    536c666 View commit details
    Browse the repository at this point in the history

  13. Rename PixelRecHits.{h,cu} to PixelRecHitGPUKernel.{h,cu}

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    90834a7 View commit details
    Browse the repository at this point in the history

  14. Use gpuClustering::invalidModuleId instead of 9999

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    c099c10 View commit details
    Browse the repository at this point in the history

  15. Update comments about GPU_SMALL_EVENTS

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    c362200 View commit details
    Browse the repository at this point in the history

  16. Consistently use gpuClustering::maxNumModules

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    f6924bb View commit details
    Browse the repository at this point in the history

  17. Extend the SiPixelCluster constructor

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    f217a05 View commit details
    Browse the repository at this point in the history

  18. Remove forwarding header file

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    1894353 View commit details
    Browse the repository at this point in the history

  19. Added comments

    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    3f06c72 View commit details
    Browse the repository at this point in the history

  20. General code cleanup 

    General clean up of the pixel local reconstructon code:
  - improve comments, remove commented out code and obsolete comments
  - replace std::cout with LogDebug
  - update variable names to follow the coding rules
    @fwyzard
    fwyzard committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    9dc3931 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. General code cleanup 

    General clean up of the pixel local reconstructon code:
  - improve comments, remove commented out code and obsolete comments
  - replace std::cout with LogDebug
  - update variable names to follow the coding rules
  - reuse existing constants
  - remove some obsolete code
    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    b7c5879 View commit details
    Browse the repository at this point in the history

  2. General code cleanup 

    General clean up of the pixel local reconstructon code:
  - improve comments, remove commented out code and obsolete comments
  - add notes about the original cpu code
  - update variable names to follow the coding rules
    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    85d69f9 View commit details
    Browse the repository at this point in the history

  3. Use std::size instead of hardcoding the array size

    @fwyzard
    fwyzard committed Dec 16, 2020
    1 Configuration menu
    Copy the full SHA
    7ae9dde View commit details
    Browse the repository at this point in the history

  4. Update comments

    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    949a08a View commit details
    Browse the repository at this point in the history

  5. Move common code to PixelClusterizerBase

    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    1037357 View commit details
    Browse the repository at this point in the history

  6. General code cleanup 

    General clean up of the pixel local reconstructon code:
  - replace std::cout with LogDebug or LogWarning
  - reuse existing constants
    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5ca25bb View commit details
    Browse the repository at this point in the history

  7. Apply code formatting

    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e78b05c View commit details
    Browse the repository at this point in the history

  8. Convert iterator-based loops to range-based loops

    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    7870594 View commit details
    Browse the repository at this point in the history

  9. Convert iterator-based loops to range-based loops

    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    6352b74 View commit details
    Browse the repository at this point in the history

  10. General code cleanup 

    General clean up of the pixel local reconstructon code:
  - improve comments
  - update variable names to follow the coding rules
    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e0fa391 View commit details
    Browse the repository at this point in the history

  11. Clarify comments and types regarding HostProduct

    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e5c8318 View commit details
    Browse the repository at this point in the history

  12. Rename siPixelRecHitHostSoA to siPixelRecHitSoAFromLegacy

    @fwyzard
    fwyzard committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    deeb33a View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Rename siPixelClustersCUDAPreSplitting to siPixelClustersPreSplitting… 

    …CUDA
    @fwyzard
    fwyzard committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    52480b6 View commit details
    Browse the repository at this point in the history

  2. Rename siPixelRecHitsCUDAPreSplitting and siPixelRecHitsLegacyPreSpli… 

    …tting to siPixelRecHitsPreSplittingCUDA and siPixelRecHitsPreSplittingLegacy
    @fwyzard
    fwyzard committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    dc20554 View commit details
    Browse the repository at this point in the history

  3. Minor cleanup of gpuPixelRecHits.h 

    Adjust code after rearranging an #ifdef GPU_DEBUG block.
Replace an if check with an assert.
    @fwyzard
    fwyzard committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    a12321f View commit details
    Browse the repository at this point in the history

  4. Use the autogenerated cfi file instead of PixelCPEFast_cfi.py

    @fwyzard
    fwyzard committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    78337cc View commit details
    Browse the repository at this point in the history

  5. Minor cleanup of SiPixelRecHitFromSOA 

      - remove unused data members;
  - rename data members for consistency;
  - migrate to LogDebug and LogWarning;
  - other minor changes;
  - apply code formatting.
    @fwyzard
    fwyzard committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    28b7aee View commit details
    Browse the repository at this point in the history

  6. Rename SiPixelRecHitFromSOA to SiPixelRecHitFromCUDA

    @fwyzard
    fwyzard committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    6a4e3e5 View commit details
    Browse the repository at this point in the history

  7. Add put tokens and apply code formatting

    @fwyzard
    fwyzard committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    90d989d View commit details
    Browse the repository at this point in the history

  8. Minor cleanup of PixelCPEFast 

      - update variablenames to follow the coding rules
  - update comments and remove obselete ones
    @fwyzard
    fwyzard committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    43edd12 View commit details
    Browse the repository at this point in the history