Skip to content

Commit

Permalink
Use std::size instead of hardcoding the array size
Browse files Browse the repository at this point in the history
  • Loading branch information
fwyzard committed Dec 16, 2020
1 parent 85d69f9 commit 7ae9dde
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions Geometry/TrackerGeometryBuilder/interface/phase1PixelTopology.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ namespace phase1PixelTopology {
bool go = true;
int n = 2;
while (go) {
for (uint8_t i = 1; i < 11; ++i) {
for (uint8_t i = 1; i < std::size(layerStart); ++i) {
if (layerStart[i] % n != 0) {
go = false;
break;
Expand All @@ -81,18 +81,18 @@ namespace phase1PixelTopology {
constexpr uint32_t maxModuleStride = findMaxModuleStride();

constexpr uint8_t findLayer(uint32_t detId) {
for (uint8_t i = 0; i < 11; ++i)
for (uint8_t i = 0; i < std::size(layerStart); ++i)
if (detId < layerStart[i + 1])
return i;
return 11;
return std::size(layerStart);
}

constexpr uint8_t findLayerFromCompact(uint32_t detId) {
detId *= maxModuleStride;
for (uint8_t i = 0; i < 11; ++i)
for (uint8_t i = 0; i < std::size(layerStart); ++i)
if (detId < layerStart[i + 1])
return i;
return 11;
return std::size(layerStart);
}

constexpr uint32_t layerIndexSize = numberOfModules / maxModuleStride;
Expand Down

0 comments on commit 7ae9dde

Please sign in to comment.