Fix muon IP sign #475
Closed
Fix muon IP sign #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[11.0.X] fix alignment validation plotting macro
…make charged hadrons from them.
…or matched tracks, and then hfem satellites.
|
Please update |
gpetruc-bot
previously requested changes
Jan 8, 2020
There was a problem hiding this comment.
Automatic test report for 1329431
- gitlab pipeline at https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/1329431/builds
- status: FAILURE (see link above for failed jobs)
Code integration
Code checks passed for this PR
Code format failed for this PR, see patch
Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense.
Tests
- Long test data102X (10000 events): passed, with differences; dqm plots: all, diff
- Long test data106Xul17 (9000 events): passed, no significant changes; dqm plots: all, diff
- Long test data106Xul18 (9000 events): passed, with differences; dqm plots: all, diff
- Long test data94X (10000 events): passed, no significant changes; dqm plots: all, diff
- Long test data94X2016 (10000 events): passed, with differences; dqm plots: all, diff
- Long test data94Xv2 (10000 events): passed, no significant changes; dqm plots: all, diff
- Long test mc102X (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc106Xul16 (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc106Xul17 (9000 events): passed, no significant changes; dqm plots: all, diff
- Long test mc106Xul18 (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc94X (10000 events): passed, no significant changes; dqm plots: all, diff
- Long test mc94X2016 (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc94Xv2 (9000 events): passed, no significant changes; dqm plots: all, diff
- Test mc_94Xv2: passed
- Test mc_102X: passed
- Test data_94X: passed
- Test data_102X: passed
arizzi
added
to be tested by bot
and removed
code checks ok (bot)
code format failed (bot)
dqm config update (bot)
test failed (bot)
labels
gpetruc-bot
added
test scheduled (bot)
test started (bot)
and removed
to be tested by bot
test scheduled (bot)
labels
|
Automatic test started, see https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/1329917/builds |
gpetruc-bot
reviewed
Jan 8, 2020
There was a problem hiding this comment.
Automatic test report for 1329917
- gitlab pipeline at https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/1329917/builds
- outputs at https://cms-nanoaod-integration.web.cern.ch/integration/test_pr_475/
Code integration
Code checks passed for this PR
Code format passed for this PR
Tests
- Long test data102X (10000 events): passed, with differences; dqm plots: all, diff
- Long test data106Xul17 (9000 events): passed, with differences; dqm plots: all, diff
- Long test data106Xul18 (9000 events): passed, with differences; dqm plots: all, diff
- Long test data80X (10000 events): passed, with differences; dqm plots: all, diff
- Long test data94X (10000 events): passed, with differences; dqm plots: all, diff
- Long test data94X2016 (10000 events): passed, with differences; dqm plots: all, diff
- Long test data94Xv2 (10000 events): passed, with differences; dqm plots: all, diff
- Long test mc102X (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc106Xul16 (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc106Xul17 (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc106Xul18 (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc80X (10000 events): passed, with differences; dqm plots: all, diff
- Long test mc94X (10000 events): passed, with differences; dqm plots: all, diff
- Long test mc94X2016 (9000 events): passed, with differences; dqm plots: all, diff
- Long test mc94Xv2 (9000 events): passed, with differences; dqm plots: all, diff
- Test mc_94Xv2: passed
- Test mc_102X: passed
- Test data_94X: passed
- Test data_102X: passed
Disk size report
| Sample | kb/event | ref kb/event | diff |
|---|---|---|---|
| TTbar MC 102X | 1.926 | 1.917 | 0.009 ( +0.4% ) |
| TTbar MC 94Xv1 | 1.990 | 1.983 | 0.007 ( +0.4% ) |
| TTbar MC 94Xv2 | 2.026 | 2.018 | 0.008 ( +0.4% ) |
| TTbar MC 94X2016 | 1.813 | 1.805 | 0.009 ( +0.5% ) |
| TTbar MC 80X | 1.942 | 1.934 | 0.008 ( +0.4% ) |
| Data 102X | 1.014 | 1.006 | 0.007 ( +0.7% ) |
| Data 94Xv1 | 0.972 | 0.966 | 0.007 ( +0.7% ) |
| Data 80X | 0.815 | 0.808 | 0.007 ( +0.9% ) |
peruzzim
force-pushed
the
master-cmsswmaster
branch
from
77ef706
to
7374762
Compare
|
replaced by #479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the dxy wrt BeamSpot for muons (#462) and fixes the sign of the IP to be curvature based rather than lifetime based ( https://its.cern.ch/jira/browse/CMSMUONS-311 )