-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0.X] fix alignment validation plotting macro #28527
Conversation
type bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_0_X. It involves the following packages: Alignment/OfflineValidation @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
can test be started here? It would be good to include this PR for 11.0.0 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Backport of #28516
PR description:
Trivial bug-fix of off-by-one issue introduced in PR #27984
PR validation:
Plotting of alignment PV Validation now works.
if this PR is a backport please specify the original PR:
Backport of #28516