generated from proofoftom/buidler-waffle-typechain-quasar
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Zupass User Registry #727
Merged
yuetloo
merged 4 commits into
clrfund:develop
from
privacy-scaling-explorations:feat/zupass-registry
Mar 2, 2024
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
// SPDX-License-Identifier: GPL-3.0 | ||
|
||
pragma solidity ^0.6.12; | ||
|
||
import '@openzeppelin/contracts/access/Ownable.sol'; | ||
|
||
import './IUserRegistry.sol'; | ||
|
||
/** | ||
* @dev A simple user registry managed by a trusted entity. | ||
*/ | ||
contract ZupassUserRegistry is Ownable, IUserRegistry { | ||
|
||
mapping(address => bool) private users; | ||
mapping(uint256 => bool) private semaphoreIds; | ||
mapping(address => uint256) private userTosemaphoreId; | ||
|
||
// Events | ||
event UserAdded(address indexed _user, uint256 _semaphoreId); | ||
event UserRemoved(address indexed _user); | ||
|
||
/** | ||
* @dev Add verified unique user to the registry. | ||
*/ | ||
function addUser(address _user, uint256 _semaphoreId) | ||
external | ||
onlyOwner | ||
{ | ||
require(_user != address(0), 'UserRegistry: User address is zero'); | ||
require(!users[_user], 'UserRegistry: User already verified'); | ||
users[_user] = true; | ||
crisgarner marked this conversation as resolved.
Show resolved
Hide resolved
|
||
semaphoreIds[_semaphoreId] = true; | ||
userTosemaphoreId[_user] = _semaphoreId; | ||
emit UserAdded(_user, _semaphoreId); | ||
} | ||
|
||
/** | ||
* @dev Remove user from the registry. | ||
*/ | ||
function removeUser(address _user) | ||
external | ||
onlyOwner | ||
{ | ||
require(users[_user], 'UserRegistry: User is not in the registry'); | ||
uint256 _semaphoreId = userTosemaphoreId[_user]; | ||
delete users[_user]; | ||
delete semaphoreIds[_semaphoreId]; | ||
delete userTosemaphoreId[_user]; | ||
emit UserRemoved(_user); | ||
} | ||
|
||
/** | ||
* @dev Check if the user is verified. | ||
*/ | ||
function isVerifiedUser(address _user) | ||
override | ||
external | ||
view | ||
returns (bool) | ||
{ | ||
return users[_user]; | ||
} | ||
|
||
/** | ||
* @dev Check if the semaphore Id is verified. | ||
*/ | ||
function isVerifiedSemaphoreId(uint256 _semaphoreId) | ||
crisgarner marked this conversation as resolved.
Show resolved
Hide resolved
|
||
external | ||
view | ||
returns (bool) | ||
{ | ||
return semaphoreIds[_semaphoreId]; | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick but I'd say
SemaphoreUserRegistry
would be more fitting for what this registry doesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to change the name to
SemaphoreUserRegistry
. This just means that the registry can be used to integrate with any system that can generate a unique semaphore id, not just by Zupass.