added Zupass User Registry #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuetloo
reviewed
Mar 2, 2024
|
@crisgarner thank you for the PR. |
samajammin
reviewed
Mar 5, 2024
| /** | ||
| * @dev A simple user registry managed by a trusted entity. | ||
| */ | ||
| contract ZupassUserRegistry is Ownable, IUserRegistry { |
There was a problem hiding this comment.
Nitpick but I'd say SemaphoreUserRegistry would be more fitting for what this registry does
There was a problem hiding this comment.
Nitpick but I'd say
SemaphoreUserRegistrywould be more fitting for what this registry does
I'm happy to change the name to SemaphoreUserRegistry. This just means that the registry can be used to integrate with any system that can generate a unique semaphore id, not just by Zupass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.