feat: adds geo_allowlist_statement_rules action
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknysh
reviewed
Feb 6, 2024
There was a problem hiding this comment.
@queue-tip thanks for the PR, it looks good.
Can you please run the following commands and commit the changes:
make init
make github/init
make readme
|
@aknysh, thanks for taking a look. I added the commit. What's next? |
|
/terratest |
aknysh
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This adds an
actionparameter togeo_allowlist_statement_rulesobjects, replacing the currently-defaultblockaction.why
This is useful for metrics collection on the geo allowlist statements
To allow the user to choose either of the following actions
references
closes #58