Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo_allowlist_statement_rules should allow the "count" action in addition to "block" #58

Closed
queue-tip opened this issue Dec 6, 2023 · 0 comments · Fixed by #59
Closed

Comments

@queue-tip
Copy link
Contributor

Describe the Feature

Currently geo_allowlist_statement_rules have a default action of block. Instead of setting a default, the user should be able to choose between block and count.

Expected Behavior

The objects in the geo_allowlist_statement_rules list allow a parameter named action with either block or count as valid values.

Use Case

It would be useful in a count-before-block configuration in order to collect metrics on geo blocking rules.

Describe Ideal Solution

I'd like an implementation similar to how other rule lists in the module allow specifying the action.

Alternatives Considered

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant