Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regex-rule): bugfix for attribute lookup #13

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

dannyibishev
Copy link
Contributor

@dannyibishev dannyibishev commented Apr 26, 2022

what

  • Added the right attribute lookup logic for the single_header and the single_query_argument blocks of code regarding the regex_pattern_set_reference_statement_rules dynamic block.

    This was done to rectify a misconfiguration and also follows the existing configuration design.

why

  • Attribute lookup failed for single_header. The following screenshot was the error I was receiving
420:                     name = single_header.value.name
│     ├────────────────
│     │ single_header.value is 1
│
│ Can't access attributes on a primitive-typed value (number).

FYI: Ignore the line number in the nippet. It's from an edited fork of your repo. But this bug does exist here as well

references

Similar issue to #10
closes #10

@dannyibishev dannyibishev requested review from a team as code owners April 26, 2022 11:10
@dannyibishev dannyibishev requested review from jhosteny and leb4r April 26, 2022 11:10
@dannyibishev
Copy link
Contributor Author

Don't know what all this formatting is that was committed by your CI. But it's not part of the contributions I made 👼

@Gowiem
Copy link
Member

Gowiem commented Apr 26, 2022

/test all

@Gowiem Gowiem added the patch A minor, backward compatible change label Apr 26, 2022
@Gowiem Gowiem self-requested a review April 26, 2022 16:41
@Gowiem Gowiem merged commit cc930d8 into cloudposse:master Apr 26, 2022
@Gowiem
Copy link
Member

Gowiem commented Apr 26, 2022

@dannyibishev Thanks for the contribution! Released as https://github.com/cloudposse/terraform-aws-waf/releases/tag/0.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants