-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue when single_header is given #10
Conversation
Tested with field_to_match = { single_header = { name = "user-agent" } } Also changed it for single_query_argument
When will this get approved? |
/test all |
Sorry for the delay. Thank you for your submission @fleralle. These changes look good. Side note, please properly fill out |
/rebuild-readme |
/test all |
We are missing tests that cover this particular set of dynamic blocks. I'm going to take the liberty to push a commit to this PR to expand our example in |
I don't see your commit and I guess that's what's holding the merge. Any ETA? |
Tested with
Also changed it for
single_query_argument
what
why
references
closes #123
, if this PR closes a GitHub issue#123