Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when single_header is given #10

Closed
wants to merge 2 commits into from

Conversation

fleralle
Copy link

@fleralle fleralle commented Dec 16, 2021

Tested with

field_to_match = {
  single_header = {
    name = "user-agent"
  }
}

Also changed it for single_query_argument

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
  • Use bullet points to be concise and to the point.

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

Tested with 
field_to_match = {
          single_header = {
            name = "user-agent"
          }
        }

Also changed it for single_query_argument
@fleralle fleralle requested review from a team as code owners December 16, 2021 20:15
@fleralle fleralle requested review from jhosteny and milldr December 16, 2021 20:15
@rahulnandan
Copy link

When will this get approved?

@korenyoni
Copy link
Member

/test all

@korenyoni
Copy link
Member

korenyoni commented Jan 20, 2022

When will this get approved?

@fleralle @rahulnandan

Sorry for the delay.

Thank you for your submission @fleralle. These changes look good.

Side note, please properly fill out what, when, and references in the PR template next time. But I will edit the PR description now and do that.

@korenyoni
Copy link
Member

/rebuild-readme

@korenyoni
Copy link
Member

/test all

@korenyoni korenyoni added bug 🐛 An issue with the system patch A minor, backward compatible change labels Jan 20, 2022
@korenyoni
Copy link
Member

We are missing tests that cover this particular set of dynamic blocks. I'm going to take the liberty to push a commit to this PR to expand our example in examples/complete accordingly.

@karaluh
Copy link

karaluh commented Feb 15, 2022

We are missing tests that cover this particular set of dynamic blocks. I'm going to take the liberty to push a commit to this PR to expand our example in examples/complete accordingly.

I don't see your commit and I guess that's what's holding the merge. Any ETA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants