Perform stack check by loading models without waiting on migrations #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this because we want to be able to call the stack checker prior to running migrations. This is so that if the stack checker fails the deployment then new migrations will not have run and we are left a clean state. Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Samze
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 8, 2024
This reverts commit f445c39. We can now run the stack checker before migrations as per cloudfoundry/cloud_controller_ng#3925. This is an improvement as we want to fail the stack checker before any migrations have run so that we are not in a state where migrations have run but the deployment has failed Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
3 tasks
…ean install Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
sethboyles
approved these changes
Aug 12, 2024
Samze
approved these changes
Aug 12, 2024
Samze
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 14, 2024
This reverts commit f445c39. We can now run the stack checker before migrations as per cloudfoundry/cloud_controller_ng#3925. This is an improvement as we want to fail the stack checker before any migrations have run so that we are not in a state where migrations have run but the deployment has failed Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 14, 2024
Changes in cloud_controller_ng:
- Perform stack check by loading models without waiting on migrations
PR: cloudfoundry/cloud_controller_ng#3925
Author: Alex Rocha <alex.rocha@broadcom.com>
Author: Sam Gunaratne <sam.gunaratne@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this because we want to be able to call the stack checker prior to running migrations. This is so that if the stack checker fails the deployment then new migrations will not have run and we are left a clean state.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests