Skip to content

Commit

Permalink
Revert "Run stack_check after DB migrations and seeds (#453)" (#454)
Browse files Browse the repository at this point in the history
This reverts commit f445c39.

We can now run the stack checker before migrations as per
cloudfoundry/cloud_controller_ng#3925.

This is an improvement as we want to fail the stack checker before any
migrations have run so that we are not in a state where migrations
have run but the deployment has failed

Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
  • Loading branch information
xandroc and Samze committed Aug 14, 2024
1 parent fc64f17 commit 8517ca8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jobs/cloud_controller_ng/templates/pre-start.sh.erb
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,14 @@ function main {
start_bosh_dns_or_consul
setup_directories
<% if spec.bootstrap && p('cc.run_prestart_migrations') %>
stack_check
perform_migration
seed_db
<% if p('cc.database_encryption.skip_validation') %>
echo "Skipping DB encryption validation"
<% else %>
validate_encryption_keys
<% end %>
stack_check
<% else %>
echo "Skipping DB migrations and seeds"
<% end %>
Expand Down

0 comments on commit 8517ca8

Please sign in to comment.