Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C3-name-validation-fix #3496

Merged
merged 2 commits into from
Jun 20, 2023
Merged

C3-name-validation-fix #3496

merged 2 commits into from
Jun 20, 2023

Commits on Jun 20, 2023

  1. Remove package-lock.json, which should be handled at the root

    @petebacondarwin
    petebacondarwin committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1f866d6 View commit details
    Browse the repository at this point in the history

  2. [C3] fix: ensure that default project name can be used 

    If you hit enter when asked for the name of the project, you expect it
to use the default value. But the project name validation was then failing
as it was receiving undefined for the value of the input rather than the
default value.

Now the validator will be passed the default if no value was provided.
    @petebacondarwin
    petebacondarwin committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ff7e7d5 View commit details
    Browse the repository at this point in the history