C3-name-validation-fix

[petebacondarwin]

If you hit enter when asked for the name of the project, you expect it
to use the default value. But the project name validation was then failing
as it was receiving undefined for the value of the input rather than the
default value.

Now the validator will be passed the default if no value was provided.

Author has included the following, where applicable:

• [N/A] Tests - it is not really possible to automate a test for this as it requires interaction.
• Changeset (Changeset guidelines)

To test manually:

1. Run npm run build in the root to ensure the binaries are up to date.
2. Then run node ./packages/create-cloudflare/dist/cli.js
3. And hit enter.

Reviewer is to perform the following, as applicable:

• Checked for inclusion of relevant tests
• Checked for inclusion of a relevant changeset
• Checked for creation of associated docs updates
• Manually pulled down the changes and spot-tested

[changeset-bot]

🦋 Changeset detected

Latest commit: ff7e7d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5320150716/npm-package-wrangler-3496

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3496/npm-package-wrangler-3496

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5320150716/npm-package-wrangler-3496 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5320150716/npm-package-cloudflare-pages-shared-3496

Note that these links will no longer work once the GitHub Actions artifact expires.

[codecov]

Codecov Report

Merging #3496 (ff7e7d5) into main (9fd12df) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3496      +/-   ##
==========================================
+ Coverage   75.18%   75.21%   +0.02%     
==========================================
  Files         183      183              
  Lines       11055    11055              
  Branches     2904     2904              
==========================================
+ Hits         8312     8315       +3     
+ Misses       2743     2740       -3     

see 2 files with indirect coverage changes

[petebacondarwin]

I just tried this again locally and actually my fix is wrong. The fix assumes that the value will be undefined but actually it is being passed "".

I think for C3 PRs we have to be careful to actually pull down the code and run it, since there is very little test coverage, especially for interactive behaviour.

[jculvey]

I just tried this again locally and actually my fix is wrong. The fix assumes that the value will be undefined but actually it is being passed "".

Added a fix for this in my PR.