-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test
: provide timing information
#779
Conversation
test
: provide testing informationtest
: provide timing information
src/cider/nrepl/middleware/test.clj
Outdated
~@body) | ||
took# (- (System/currentTimeMillis) | ||
then#)] | ||
(reset! ~time-atom {:took-ms took# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably use names like :elapsed-time
and :elapsed-time-string/humanized
, as I find the use of took
confusing. Other terms that come to mind duration, time, etc. I recall prepl
just uses the :ms
key, so I can live with something like this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is already under :timing
you can also simply go with :ms
and :humanized
. Perhaps :timing
can become :elapsed-time
or :duration
?
src/cider/nrepl/middleware/test.clj
Outdated
~@body) | ||
took# (- (System/currentTimeMillis) | ||
then#)] | ||
(reset! ~time-atom {:took-ms took# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably use names like :elapsed-time
and :elapsed-time-string/humanized
, as I find the use of took
confusing. Other terms that come to mind duration, time, etc. I recall prepl
just uses the :ms
key, so I can live with something like this as well.
Other than my remark about the naming - everything looks good. |
All set! I also updated the PR desc with the new names and the newly implemented global key. |
@@ -1278,3 +1292,310 @@ Optional parameters:: | |||
Returns:: | |||
* `:status` done | |||
|
|||
|
|||
|
|||
=== `log-add-appender` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran lein docs
so these showed up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess Roman forgot to run this.
I've cut v0.32.0-alpha2 to play with this cider.el side |
With these changes, responses are now enhanced with the following structural changes:
Cheers - V