Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature idea: Timing information in test report #755

Closed
DerGuteMoritz opened this issue Aug 26, 2022 · 2 comments · Fixed by #779
Closed

Feature idea: Timing information in test report #755

DerGuteMoritz opened this issue Aug 26, 2022 · 2 comments · Fixed by #779

Comments

@DerGuteMoritz
Copy link

When working on optimizing test performance, it would be very handy to have timing information in the test report. Something like this:

Tested 1 namespaces in 12666 ms
Ran 75 assertions, in 17 test functions
75 passed
@vemv
Copy link
Member

vemv commented Aug 26, 2022

This sounds like a reasonable request, feel free to create a PR as elaborate (or simple) as desired.

I'm thinking different granularities should be included in the return value, e.g. per-ns, per-var, possibly more.

If a single run is for a var-query that will exercise two namespaces with two vars each, I would expect:

  • the timing info for each of the 4 vars
  • the timing info for each of the 2 namespaces
  • the total timing info.

(quite obviously, it's up to cider.el to decide which of this info is relevant and will be presented to the user. Might be customizable)

Sounds good? Is it something you'd be willing to work on?

I'd be happy to assist with reviewing and tweaks.

Cheers - V

@DerGuteMoritz
Copy link
Author

Thanks for the swift reply! Your thoughts make sense and sound good to me 👍 In principle I'd be willig to work on this but at the moment I can't make time for it. I'll post another update here when I get to it. If anyone else is inclined to start working on it in the meantime, be sure to also post here so that we don't end up duplicating efforts 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants