Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: intermitent test #347

Merged
merged 3 commits into from
Mar 24, 2022
Merged

fix: intermitent test #347

merged 3 commits into from
Mar 24, 2022

Conversation

RafaelGSS
Copy link
Contributor

This test was intermitent, because autocannon is not available globally (sometimes).

@RafaelGSS RafaelGSS requested a review from mcollina March 24, 2022 02:08
@RafaelGSS RafaelGSS linked an issue Mar 24, 2022 that may be closed by this pull request
Fix flaky tests #332
Closed
@mcollina
Copy link
Contributor

CI was not happy

mcollina
mcollina approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS RafaelGSS merged commit 2398e2f into main Mar 24, 2022
@github-actions github-actions bot mentioned this pull request Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flaky tests
2 participants
@RafaelGSS @mcollina