Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests #332

Closed
RafaelGSS opened this issue Feb 2, 2022 · 0 comments · Fixed by #347
Closed

Fix flaky tests #332

RafaelGSS opened this issue Feb 2, 2022 · 0 comments · Fixed by #347
Labels
good first issue Good for newcomers

Comments

@RafaelGSS
Copy link
Contributor

https://github.com/clinicjs/node-clinic/actions/workflows/ci.yml?query=is%3Afailure

As titled. There are some flaky tests mainly in the heapprofiler-full.test.js. Would be great to solve it instead of running it several times.
@RafaelGSS RafaelGSS added the good first issue Good for newcomers label Feb 2, 2022
@RafaelGSS RafaelGSS linked a pull request Mar 24, 2022 that will close this issue
fix: intermitent test #347
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: intermitent test clinicjs/node-clinic
1 participant
@RafaelGSS